-
Notifications
You must be signed in to change notification settings - Fork 0
c8d/resolver: Use hosts from daemon configuration #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Paweł Gronowski <[email protected]>
3e5d530 to
435e8f7
Compare
|
It works, but only if the Line 171 in 0db5099
However, the non-c8d Docker does advise against using explicit schema: Lines 194 to 203 in 0db5099
And because the The non-c8d Docker doesn't need the schemas, because the behaviour for handling insecure registries is first to try the HTTPS ignoring the certificate errors, and if that fails fallback to HTTP. |
Signed-off-by: Paweł Gronowski <[email protected]>
eb1aeb4 to
271ba4e
Compare
|
I added the fallback to the HTTP and changed the |
|
tested, but doesn't work for me.
|
|
|
||
| for _, v := range daemon.configStore.InsecureRegistries { | ||
| u, err := url.Parse(v) | ||
| if err != nil && !strings.HasPrefix(v, "http://") && !strings.HasPrefix(v, "https://") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parsing registry:5000 without a scheme doesn't trigger an error
Trying to parse a hostname and path without a scheme is invalid but may not necessarily return an error, due to parsing ambiguities
indeed, registry:5000 is parsed as Scheme="registry",...
This makes the containerd pull/push respect the insecureRegistries configuration.
Signed-off-by: Paweł Gronowski [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)