Conversation
ndeloof
force-pushed
the
image_inspect
branch
3 times, most recently
from
fe5d962 to
2ccda73
Compare
ndeloof
force-pushed
the
image_inspect
branch
4 times, most recently
from
544f75c to
13c76d3
Compare
rumpl
approved these changes
Jul 8, 2022
requies passing context around Signed-off-by: Nicolas De Loof <[email protected]>
vvoland
approved these changes
Jul 8, 2022
This was referenced Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
implemented image inspect (
GetImage) on top of containerd store- How I did it
copy/pasted implementation code from https://github.com/rumpl/moby/tree/containerd-store
passed
context.Contextdown to the many places this method is used