daemon: containerStart(): optimize logic #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
rumpl_container_start_cleanup
branch
from
36e5a40 to
e1906d6
Compare
- combine the two "if daemon.UsesSnapshotter()" branches - newContainerOpts was only used if a container had to be created, so skip creating options (and look up the image) if the container was found. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
rumpl_container_start_cleanup
branch
from
e1906d6 to
ce5b73f
Compare
rumpl
approved these changes
Aug 24, 2022
Collaborator
Author
|
CI is still happy, so let me get this one in 👍 |
Collaborator
Author
|
When upstreaming, should be combined: |
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simplification of the logic in this function;