Make build work #28
Merged
Make build work #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
commented
Jul 27, 2022
Comment on lines
267
to
282
| if req.Exporter != "" { | ||
| req.Exporter = client.ExporterImage | ||
| exp, err := w.Exporter(req.Exporter, c.opt.SessionManager) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| reposAndTags, err := sanitizeRepoAndTags(strings.Split(req.ExporterAttrs["name"], ",")) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| var names []string | ||
| for _, tag := range reposAndTags { | ||
| names = append(names, tag.String()) | ||
| } | ||
|
|
||
| req.ExporterAttrs["name"] = strings.Join(names, ",") |
Owner
Author
There was a problem hiding this comment.
@tonistiigi without this change docker buildx build -t test will create an image named test but not docker.io/library/test, any ideas why this happens?
With a normal daemon buildx build will give the image the canonical name but for some reason here it doesn't. I tried to understand what is going on but I don't really know who canonicalizes the name, buildx or the daemon?
Owner
Author
There was a problem hiding this comment.
An issue is created for this over at moby/buildkit#2986
rumpl
force-pushed
the
feat-build
branch
2 times, most recently
from
896277a to
84c83cf
Compare
vvoland
approved these changes
Jul 29, 2022
Collaborator
vvoland
left a comment
vvoland
left a comment
There was a problem hiding this comment.
LGTM; also tested it with some simple Dockerfiles on my side and seems to work
Signed-off-by: Djordje Lukic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker buildand buildx works with this code.