c8d/commit: Fix choosing base manifest, set dangling name, fix errdefs #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
force-pushed
the
c8d-commit-platform-fix
branch
2 times, most recently
from
7afdf1e to
02e253f
Compare
vvoland
force-pushed
the
c8d-commit-platform-fix
branch
2 times, most recently
from
a84d38f to
8ef462f
Compare
The base image should match the container's platform. This also fixes an issue where the parsed manifest is empty because the image's target is manifest list instead of manifest. Signed-off-by: Paweł Gronowski <[email protected]>
The check for errdefs.IsNotFound didn't work as expected because it used the docker/errdefs instead of containerd/errdefs. Signed-off-by: Paweł Gronowski <[email protected]>
Previously the image was stored with name being set to its digest. This caused two images to exists after a successful commit because the image is also tagged to a desired name by caller of `CommitImage`. Signed-off-by: Paweł Gronowski <[email protected]>
Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
c8d-commit-platform-fix
branch
from
8ef462f to
7cf3e8f
Compare
rumpl
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few bugs in the
docker commit.