Skip to content

Add brownout ranges for deprecated dependency api #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simi merged 1 commit into from
Feb 23, 2023
Merged

Add brownout ranges for deprecated dependency api #3477

simi merged 1 commit into from
Feb 23, 2023

Conversation

@segiddins
Copy link
Contributor

@segiddins segiddins commented Feb 22, 2023

Pursuant to the rfc / blog post

Brownout ranges resolve to:

[2023-03-22 00:00:00 UTC..2023-03-22 00:05:00 UTC,
 2023-03-29 00:00:00 UTC..2023-03-29 00:10:00 UTC,
 2023-03-29 01:00:00 UTC..2023-03-29 01:10:00 UTC,
 2023-03-29 02:00:00 UTC..2023-03-29 02:10:00 UTC,
 2023-03-29 03:00:00 UTC..2023-03-29 03:10:00 UTC,
 2023-03-29 04:00:00 UTC..2023-03-29 04:10:00 UTC,
 2023-03-29 05:00:00 UTC..2023-03-29 05:10:00 UTC,
 2023-03-29 06:00:00 UTC..2023-03-29 06:10:00 UTC,
 2023-03-29 07:00:00 UTC..2023-03-29 07:10:00 UTC,
 2023-03-29 08:00:00 UTC..2023-03-29 08:10:00 UTC,
 2023-03-29 09:00:00 UTC..2023-03-29 09:10:00 UTC,
 2023-03-29 10:00:00 UTC..2023-03-29 10:10:00 UTC,
 2023-03-29 11:00:00 UTC..2023-03-29 11:10:00 UTC,
 2023-03-29 12:00:00 UTC..2023-03-29 12:10:00 UTC,
 2023-03-29 13:00:00 UTC..2023-03-29 13:10:00 UTC,
 2023-03-29 14:00:00 UTC..2023-03-29 14:10:00 UTC,
 2023-03-29 15:00:00 UTC..2023-03-29 15:10:00 UTC,
 2023-03-29 16:00:00 UTC..2023-03-29 16:10:00 UTC,
 2023-03-29 17:00:00 UTC..2023-03-29 17:10:00 UTC,
 2023-03-29 18:00:00 UTC..2023-03-29 18:10:00 UTC,
 2023-03-29 19:00:00 UTC..2023-03-29 19:10:00 UTC,
 2023-03-29 20:00:00 UTC..2023-03-29 20:10:00 UTC,
 2023-03-29 21:00:00 UTC..2023-03-29 21:10:00 UTC,
 2023-03-29 22:00:00 UTC..2023-03-29 22:10:00 UTC,
 2023-03-29 23:00:00 UTC..2023-03-29 23:10:00 UTC,
 2023-04-03 00:00:00 UTC..2023-04-04 00:00:00 UTC,
 2023-04-10 00:00:00 UTC...]

@segiddins segiddins requested review from indirect and simi February 22, 2023 18:46
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3477 (d5626fb) into master (5a3a3ec) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3477      +/-   ##
==========================================
+ Coverage   97.80%   97.81%   +0.01%     
==========================================
  Files         166      167       +1     
  Lines        4145     4169      +24     
==========================================
+ Hits         4054     4078      +24     
  Misses         91       91
Impacted Files Coverage Δ
app/controllers/api/v1/dependencies_controller.rb 100.00% <100.00%> (ø)
app/avo/actions/block_user.rb 100.00% <0.00%> (ø)
app/avo/resources/user_resource.rb 97.82% <0.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

indirect
indirect approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I got curious how much time to expect per request checking the array of ranges, so I benchmarked it: 2.75us (microsonds, not milliseconds). I think we'll be good, haha.

showing my work: https://gist.github.com/indirect/46f788c871679f432857c0185853e5bd

@simi simi merged commit e049fdb into rubygems:master Feb 23, 2023
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to staging February 23, 2023 00:11 Inactive
@rubygems-org-shipit rubygems-org-shipit bot temporarily deployed to production February 24, 2023 19:22 Inactive
@segiddins segiddins deleted the segiddins/dependency-api-brownout branch April 3, 2023 16:46
@jenshenny jenshenny mentioned this pull request Apr 3, 2023
Merged
@philr philr mentioned this pull request Apr 10, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@indirect indirect indirect approved these changes

@simi simi simi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@segiddins @indirect @simi