Add ability to loop sounds #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently you can play music on a loop but not sounds, the `Mix_PlayChannel` function we're using to play sounds supports passing a value for the number of loops, so we can send `-1` here to loop until the sound is stopped :)
Now that we're looping sounds, it's more useful to be able to stop playing a sound, we provide that functionality by recording the sound channel that was used and stopping that channel.
Contributor
|
Looks great, @mariovisic. (This also addresses #55) |
blacktm
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can play music on a loop but not sounds, the
Mix_PlayChannelfunction we're using to play sounds supports passing avalue for the number of loops, so we can send
-1here to loop untilthe sound is stopped :)