Limit the amount of fonts to be cached #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would cache every font that the user created that had a unique font face, size and any styles (such as bold or italic). This meant that if you increased the font size by a tiny fraction every frame, then it would create a new font object every frame, resulting in 1000s of fonts that we cached and never let go. In these circumstances it's easier to not attempt to cache all of the fonts, and so setting a limit of 100 fonts to cache as the maximum means that we can limit the amount of memory the program will consume, 100 font variations should be plenty for most programs and programs that use more will pay a small performance penalty but they won't have uncontrolled memory growth any more.
blacktm
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would cache every font that the user created that had a unique
font face, size and any styles (such as bold or italic).
This meant that if you increased the font size by a tiny fraction every frame,
then it would create a new font object every frame, resulting in 1000s of fonts
that we cached and never let go. In these circumstances it's easier to not
attempt to cache all of the fonts, and so setting a limit of 100 fonts to cache
as the maximum means that we can limit the amount of memory the program will
consume, 100 font variations should be plenty for most programs and programs
that use more will pay a small performance penalty but they won't have
uncontrolled memory growth any more.