Add scaling to tileset and fix spacing bug #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It would have been good to be able to get |
Previously: to scale the size of tiles displayed in a tileset, you would need to multiply the tile width/height, the image width/height as well as the spacing and padding values by the scale. This works but means that you need to know the dimensions of the tileset image, rather than having it be detected and you have to multiply each value which can be confusing. This patch still allows you to manually set those values if you wish but introduces a 'scale' attribute which will do the work for you, meaning now you can set a scale without having to specify the width/height of the tileset image manually and multiply all attributes. This patch also fixes a bug where the spacing was not being calculated correctly, it was using `(tile_x + spacing) * tile_width` which is incorrect, it is now: `tile_x * (spacing + tile_width)`
mariovisic
force-pushed
the
tileset_scaling
branch
from
4b6df19 to
f26d1ff
Compare
blacktm
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: to scale the size of tiles displayed in a tileset, you would need
to multiply the tile width/height, the image width/height as well as the
spacing and padding values by the scale. This works but means that you need to
know the dimensions of the tileset image, rather than having it be detected and
you have to multiply each value which can be confusing.
This patch still allows you to manually set those values if you wish but
introduces a 'scale' attribute which will do the work for you, meaning now you
can set a scale without having to specify the width/height of the tileset image
manually and multiply all attributes.
This patch also fixes a bug where the spacing was not being calculated
correctly, it was using
(tile_x + spacing) * tile_widthwhich is incorrect,it is now:
tile_x * (spacing + tile_width)