Free textures when updating text #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After refactoring our text class to use the new texture rendering method, changing the text means a new texture but we don't free up the old one in C land. When updating text we re-assign the `@texture` instance. Currently we handle freeing SDL surfaces by setting the `@pixel_data` value to `nil`. As this is a C object, the ruby garbage collector will call the correct free function in C. For textures though we don't hold a wrapped pointer to the C open GL texture object, we could do, but we don't actually use it for anything in ruby, so it would be easy to accidentally alter or remove that code causing a memory leak. So to free up our texture we can now explicitly call delete and pass our texture_id, this way it's obvious what that code does and why we need it :)
mariovisic
force-pushed
the
free_textures
branch
from
b00f555 to
359075e
Compare
blacktm
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring our text class to use the new texture rendering method,
changing the text means a new texture but we don't free up the old one in C
land.
When updating text we re-assign the
@textureinstance. Currently wehandle freeing SDL surfaces by setting the
@pixel_datavalue tonil.As this is a C object, the ruby garbage collector will call the correct
free function in C.
For textures though we don't hold a wrapped pointer to the C open GL
texture object, we could do, but we don't actually use it for anything
in ruby, so it would be easy to accidentally alter or remove that code
causing a memory leak. So to free up our texture we can now explicitly
call delete and pass our texture_id, this way it's obvious what that
code does and why we need it :)