Add error handling around open windows #215
Conversation
Add two errors: 1) prevent users from calling 'show' multiple times as it currently doesn't function 2) prevent users directly drawing objects outside of the render block (this does not work as the window is not yet ready)
blacktm
left a comment
blacktm
left a comment
There was a problem hiding this comment.
Cool, seems to work. Would need to add guards to all the "renderable" classes. Also, we may need to keep @@open_window set to true even after close is called, because this will still cause a crash when a key is pressed:
require 'ruby2d'
on :key do |e|
close
end
show
show
Great, I tested this and it works well 👍 |
For some reason I had missed these classes earlier. Also remove one call in Triangle to the window check, as we only need to perform it on direct draw calls, not when the private render method is called (as the window is always ready in that case).
oh wierd, not sure how I missed some of them. Fixed in 851acf4 |
|
This is now ready for re-review when you have a spare moment @blacktm 👍 |
2 participants
Add two errors:
doesn't function
(this does not work as the window is not yet ready)