Tileset rendering refactor #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add the ability to flip and rotate tiles Lastly extract the logic to check if an image exists to the `Image` class for re-use.
We don't need this any more as we're using `Image` and `Texture` to render out tiles now :)
Use keyword arguments so the user can easily specify either flip or rotation. Add these to the tileset rendering test to ensure it doesn't break :)
I'd like to factor the code which sets the window icon, so let's test it first :)
The window icon was the last place we were using the R2D_Image C struct. I've updated this code to use the new image functions to directly get a surface and removed the remaining unused image code.
These methods were used by Sprite/Tileset/Text and Image, but now they use the new function and directly provide vertices information. So these can be removed.
This texture rendering function now replaces the old one, so we can remove the 'new' word.
blacktm
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the C R2D_Image code can be removed, I've updated the window icon to use the new rendering functions as well.
Tiles can now be rotated and flipped as well, using the logic that already exists in Vertices.
I've removed the arguments for the direct draw calls, as it doesn't make a huge amount of sense and it was simpler to leave them off, we could re-add them later if there's a need.