Sprite rendering refactor #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Vertices class didn't have crop functionality which is required for sprites, so that has been added in now :) The internal flip_ variables inside the sprite can now be removed as the Vertices class is now responsible for transforming the width/height/x and y co-ordinates when flipping the image.
This sprite code is no longer used as we're using Image and Texture to do our rendering now, and we calculate transforms like scaling/cropping/rotating and mirroring in the Vertices ruby class.
We can add exception / error handling in the `ext_load_image` method rather than directly in the sprite.
blacktm
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only a few small changes to the code in the actual
Spriteclass. The big change is moving the flipping code to theVerticesclass so it can be re-used later byTilesetand then we get cropping and flipping for free there :)All of the sprite C code can go as we're using
ImageandTextureto do out rendering now.Lastly i've updated the methods which load SDL textures externally to be class methods as they don't have any state and in
Spritewe need to load an image texture, so class method is easier :)I've tested the sprite manually and it looks like it matches the
mainbranch. The animations all look like they're workingScaling also seems to work: