Remove r/g/b/a attributes from Renderable classes #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As talked about in ruby2d#160, it doesn't make a lot of sense to have these forwarding to `foo.color`, when `foo.color.r/g/b/a` can be used directly. This (imo) breaks the single responsibility principle, and adds duplication that doesn't need to be there. - Removed all of the forwarding attributes. - Updated tests and made sure that they build.
blacktm
approved these changes
Aug 7, 2021
Member
|
Thanks for taking the initiative on this @collindonnell! Just updated the branch, fixed conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As talked about in #160, it doesn't make a lot of sense to have these forwarding to
foo.color, whenfoo.color.r/g/b/acan be used directly. This (imo) breaks the single responsibility principle, and adds duplication that doesn't need to be there.