Fix compiler warnings for string literals #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Literals are treated as read-only and so when we pass them to a function they should be set to const as they cannot be modified. This clears up all of my compiler warnings, previously I had 7.
Contributor
Author
|
You can see the previous warnings on the travis CI build: https://app.travis-ci.com/github/ruby2d/ruby2d/builds/233724437#L430-L488 |
blacktm
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literals are treated as read-only and so when we pass them to a function
they should be set to const as they cannot be modified. This clears up
all of my compiler warnings, previously I had 7.