Skip to content

Fix spec for support faraday 2#561

Merged
pboling merged 1 commit intoruby-oauth:masterfrom
ryogift:support-faraday2
Feb 14, 2022
Merged

Fix spec for support faraday 2#561
pboling merged 1 commit intoruby-oauth:masterfrom
ryogift:support-faraday2

Conversation

@ryogift
Copy link
Copy Markdown

@ryogift ryogift commented Jan 15, 2022

Fixed specs with reference to the upgrade guide to support Faraday 2.0.
Fixed Faraday::Builder#build cannot be used.

https://github.com/lostisland/faraday/blob/main/UPGRADING.md#others

Faraday::Builder#build method is not exposed through Faraday::Connection anymore and does not reset the handlers if called multiple times. This method should be used internally only.

Related to the following issues.
#558
#559

@pboling pboling merged commit 21f303d into ruby-oauth:master Feb 14, 2022
@jrochkind
Copy link
Copy Markdown

jrochkind commented Feb 16, 2022

Hi, I'm looking at backporting to 1-4-stable, and I noted.... while the gemspec allows faraday 2.x, it may not actually be USED in CI, because of the linting dependency on danger ~> 8.4:

https://github.com/oauth-xx/oauth2/blob/7564b818778daebc1be830bddb31edfddffeb520/Gemfile#L16

8.4.2 is the latest release of danger, and does not allow faraday 2.0. https://rubygems.org/gems/danger/versions/8.4.2

I am confused trying to find the latest CI run here to look in logs for the bundle install output to see if faraday 2.0 is really being tested or not -- so I'm not certain.

Locally, if I manually comment out the danger dependency in Gemfile, I can update to faraday 2.2.0, and bundle exec rspec is green on master at commit da05429.

So tests are passing with faraday 2.x, but I'm not sure that CI is going to run with faraday 2.x, and it requires local changes to Gemfile to run locally with faraday 2.x and bundle exec rspec.

Filed with danger at danger/danger#1349

(And, wow, there is a serious chain of cascading dependency changes necessary to get faraday 2.x actually working).

jrochkind pushed a commit to jrochkind/oauth2 that referenced this pull request Feb 16, 2022
jrochkind pushed a commit to jrochkind/oauth2 that referenced this pull request Feb 17, 2022
jrochkind pushed a commit to jrochkind/oauth2 that referenced this pull request Feb 17, 2022
pboling pushed a commit that referenced this pull request Feb 17, 2022
#569)

* Backport: Fix spec for support faraday 2 (#561)

Co-authored-by: Ryo Takahashi <[email protected]>

* Additional changes ported back from master to allow faraday 1.x and 2.x

Co-authored-by: Ryo Takahashi <[email protected]>
Co-authored-by: Ryo Takahashi <[email protected]>
@pboling pboling added this to the 2.0.0 milestone Feb 18, 2022
@pboling pboling added the in Changelog Has been added to Changelog label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in Changelog Has been added to Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants