Fix spec for support faraday 2#561
Fix spec for support faraday 2#561pboling merged 1 commit intoruby-oauth:masterfrom ryogift:support-faraday2
Conversation
|
Hi, I'm looking at backporting to 1-4-stable, and I noted.... while the gemspec allows faraday 2.x, it may not actually be USED in CI, because of the linting dependency on 8.4.2 is the latest release of I am confused trying to find the latest CI run here to look in logs for the Locally, if I manually comment out the So tests are passing with faraday 2.x, but I'm not sure that CI is going to run with faraday 2.x, and it requires local changes to Gemfile to run locally with faraday 2.x and Filed with danger at danger/danger#1349 (And, wow, there is a serious chain of cascading dependency changes necessary to get faraday 2.x actually working). |
Co-authored-by: Ryo Takahashi <[email protected]>
Co-authored-by: Ryo Takahashi <[email protected]>
Co-authored-by: Ryo Takahashi <[email protected]>
#569) * Backport: Fix spec for support faraday 2 (#561) Co-authored-by: Ryo Takahashi <[email protected]> * Additional changes ported back from master to allow faraday 1.x and 2.x Co-authored-by: Ryo Takahashi <[email protected]> Co-authored-by: Ryo Takahashi <[email protected]>
Fixed specs with reference to the upgrade guide to support Faraday 2.0.
Fixed
Faraday::Builder#buildcannot be used.https://github.com/lostisland/faraday/blob/main/UPGRADING.md#others
Related to the following issues.
#558
#559