Skip to content

Conversation

@eregon
Copy link
Member

@eregon eregon commented Dec 13, 2025

* See discussion in rake-compiler/rake-compiler#247
  it is messy if that's not the case and also creates inconsistencies
  based on which Java tool/executable is used.
@eregon
Copy link
Member Author

eregon commented Dec 13, 2025

It works well, and Node.js path.join does the right thing:
https://github.com/ruby/setup-ruby/actions/runs/20197116199/job/57982688126?pr=836#step:3:36

Adding C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.9-10.0\x64\bin to Path
...
Run # Show PATH with Powershell
C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\21.0.9-10.0\x64\bin
D:\jruby-10.0.2.0\bin

@eregon eregon merged commit ac793fd into ruby:master Dec 13, 2025
209 checks passed
@eregon eregon deleted the java_home_bin_in_path branch December 13, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant