Skip to content

Fix Integer#ceildiv to respect #coerce - #7118

Merged
mrkn merged 1 commit into
ruby:masterfrom
kyanagi:integer-ceildiv-should-respect-coerce
Jan 22, 2023
Merged

Fix Integer#ceildiv to respect #coerce#7118
mrkn merged 1 commit into
ruby:masterfrom
kyanagi:integer-ceildiv-should-respect-coerce

Conversation

@kyanagi

@kyanagi kyanagi commented Jan 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Since Integer#div, Integer#fdiv, etc respect #coerce, so should #ceildiv.

c = Object.new
def c.coerce(other) = [other, 10]

p 1234 / c          # => 123
p 1234.div(c)       # => 123
p 1234.quo(c)       # => (617/5)
p 1234.fdiv(c)      # => 123.4
p 1234.ceildiv(c)   # => in `ceildiv': undefined method `-@' for #<Object:0x000000010250ad68> (NoMethodError)

@nobu
nobu requested a review from mrkn January 16, 2023 08:36
@mrkn
mrkn merged commit 20a85ab into ruby:master Jan 22, 2023
@kyanagi
kyanagi deleted the integer-ceildiv-should-respect-coerce branch November 21, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrkn mrkn mrkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kyanagi @mrkn