Skip to content

Fix private methods reported as protected when called via Symbol#to_proc - #6284

Merged
byroot merged 1 commit into
ruby:masterfrom
Shopify:to-proc-private-protected
Aug 25, 2022
Merged

Fix private methods reported as protected when called via Symbol#to_proc#6284
byroot merged 1 commit into
ruby:masterfrom
Shopify:to-proc-private-protected

Conversation

@casperisfine

@casperisfine casperisfine commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

Ref: bfa6a8d
Ref: #6018
Ref: [Bug #18826]

I noticed this while fixing some code relying on the old behavior in our app.

@byroot
byroot requested a review from jeremyevans August 25, 2022 07:29
@casperisfine casperisfine changed the title Fix private methods reported as private when called via Symbol#to_proc Fix private methods reported as protected when called via Symbol#to_proc Aug 25, 2022
@casperisfine
casperisfine force-pushed the to-proc-private-protected branch from 3e3c15e to 5f8ec9c Compare August 25, 2022 10:00

@jeremyevans jeremyevans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@byroot
byroot merged commit b2d0f78 into ruby:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants