Revert "Add {Method,UnboundMethod}#{public?,private?,protected?}" - #5974
Merged
jeremyevans merged 1 commit intoAug 10, 2022
Merged
Conversation
Contributor
Author
|
@mame That sounds good. @soutaro can you please update rbs for this change? rbs needs to be updated to remove testing of these methods: https://github.com/ruby/ruby/runs/6735184391?check_suite_focus=true#step:16:940 |
jeremyevans
force-pushed
the
revert-method-visibility-11689
branch
from
August 9, 2022 19:37
d916e3a to
d729ff9
Compare
This was referenced Aug 10, 2022
Merged
Member
|
@jeremyevans Updated RBS on #6228. Could you rebase this PR to pass the tests? 🙏 |
jeremyevans
force-pushed
the
revert-method-visibility-11689
branch
from
August 10, 2022 18:40
d729ff9 to
12a9d69
Compare
Contributor
Author
|
@soutaro Thank you very much. I rebased. If this passes CI, I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2727815 and
58dc8bf.
Visibility is an attribute of the method entry in a class, not an
attribute of the Method object.
This currently fails the bundled gem tests due to use of these methods in
rbs. That will need to be fixed before this is committed.
Fixes [#18729]
Fixes [#18751]
Fixes [#18435]