Do not autosplat array in block call just because keywords accepted - #5665
Conversation
f1e59d2 to
3dd40ff
Compare
If the block only accepts a single positional argument plus keywords, then do not autosplat. Still autosplat if the block accepts more than one position argument in addition to keywords. Autosplatting a single positional argument plus keywords made sense in Ruby 2, since a final positional hash could be used as keywords, but it does not make sense in Ruby 3. Fixes [Bug #18633]
3dd40ff to
c32f435
Compare
| ruby_version_is ''..."3.2" do | ||
| it "autosplats single argument to required arguments when a keyword rest argument is present" do | ||
| m([1, 2]) { |a, **k| [a, k] }.should == [1, {}] | ||
| end |
There was a problem hiding this comment.
If it is considered a bug, shouldn’t it be a ruby_bug guard?
There was a problem hiding this comment.
ruby_bug mostly makes sense when the change will be backported, but it will probably not be backported here (https://bugs.ruby-lang.org/issues/18633#note-2).
The main difference between ruby_bug and ruby_version_is is what should be the behavior of other Ruby implementations.
In this case I think it's probably better for other Ruby implementations to follow the 3.0 & 3.1 behavior (assuming the fix is not backported), and so ruby_version_is seems better for compatibility of these other Ruby implementations (as long as they target 3.0/3.1).
It's also not hard to follow this behavior (I did it in TruffleRuby), although it does look like a weird exception.
So I think ruby_version_is + # https://bugs.ruby-lang.org/issues/18633 above is the best here.
3 participants
If the block only accepts a single positional argument plus keywords,
then do not autosplat. Still autosplat if the block accepts more
than one position argument in addition to keywords.
Autosplatting a single positional argument plus keywords made sense
in Ruby 2, since a final positional hash could be used as keywords,
but it does not make sense in Ruby 3.
Fixes [Bug #18633]