Skip to content

[Feature #18595] Alias String#-@ as String#dedup - #5583

Merged
byroot merged 1 commit into
ruby:masterfrom
Shopify:string-dedup-alias
May 20, 2022
Merged

[Feature #18595] Alias String#-@ as String#dedup#5583
byroot merged 1 commit into
ruby:masterfrom
Shopify:string-dedup-alias

Conversation

@casperisfine

@casperisfine casperisfine commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

eregon
eregon reviewed Feb 21, 2022
View reviewed changes
Comment thread spec/ruby/core/string/dedup_spec.rb
@casperisfine
casperisfine force-pushed the string-dedup-alias branch 2 times, most recently from cd29519 to a70352d Compare February 21, 2022 12:54
eregon
eregon reviewed Feb 21, 2022
View reviewed changes
Comment thread spec/ruby/core/string/shared/dedup.rb Outdated
@casperisfine
casperisfine force-pushed the string-dedup-alias branch 2 times, most recently from 0fb1df4 to 9b666ac Compare February 21, 2022 13:49
eregon
eregon approved these changes Feb 21, 2022
View reviewed changes

@eregon eregon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@byroot
byroot merged commit 65122d0 into ruby:master May 20, 2022
headius added a commit to jruby/jruby that referenced this pull request Jan 5, 2024
@headius
Alias String#-@ as #dedup
20c5b5d 
See ruby/ruby#5583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eregon eregon eregon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@casperisfine @eregon @byroot