Provide a way to declare visibility of attributes defined by attr* methods in a single expression - v2 - #3934
Conversation
|
Thanks, I believe this change is definitely innocent :-) |
|
Yeah, I'm pretty sure too but still it's better to check :D. |
|
@mame Could you please do not merge PR until I check all commits? Otherwise I will have to create PR for every one (build is not triggered after I push commit to alreade closed PR). |
|
Unfortunately, the Solaris CI in question builds and tests only the master branch. I logged in to the CI machine and tried to reproduce the issue on a local working copy (rather than the CI setup), but I couldn't reproduce the failure. So, merging each commit is the only way to test the issue. |
|
Ah. If you could create a branch that includes separate commits, I can cherry-pick and push each commit to the master. It is okay to me if you don't mind that the branch itself will not be eventually merged. |
|
@mame Now I understand. So I will push all commits. |
Continuation of #3757. I will push each change as a separate commit to check which one fails on CI.