Skip to content

Provide a way to declare visibility of attributes defined by attr* methods in a single expression - v2 - #3934

Merged
mame merged 1 commit into
ruby:masterfrom
radarek:better_cooperation_between_attr_methods_with_public_protected_private-v2
Dec 18, 2020
Merged

Provide a way to declare visibility of attributes defined by attr* methods in a single expression - v2#3934
mame merged 1 commit into
ruby:masterfrom
radarek:better_cooperation_between_attr_methods_with_public_protected_private-v2

Conversation

@radarek

@radarek radarek commented Dec 18, 2020

Copy link
Copy Markdown
Contributor

Continuation of #3757. I will push each change as a separate commit to check which one fails on CI.

@mame

mame commented Dec 18, 2020

Copy link
Copy Markdown
Member

Thanks, I believe this change is definitely innocent :-)

@radarek

radarek commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

Yeah, I'm pretty sure too but still it's better to check :D.

@radarek

radarek commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

@mame Could you please do not merge PR until I check all commits? Otherwise I will have to create PR for every one (build is not triggered after I push commit to alreade closed PR).

@mame

mame commented Dec 18, 2020

Copy link
Copy Markdown
Member

Unfortunately, the Solaris CI in question builds and tests only the master branch. I logged in to the CI machine and tried to reproduce the issue on a local working copy (rather than the CI setup), but I couldn't reproduce the failure. So, merging each commit is the only way to test the issue.

@mame

mame commented Dec 18, 2020

Copy link
Copy Markdown
Member

Ah. If you could create a branch that includes separate commits, I can cherry-pick and push each commit to the master. It is okay to me if you don't mind that the branch itself will not be eventually merged.

@radarek

radarek commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

@mame Now I understand. So I will push all commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants