Skip to content

Move webrick library into internal test toolchain#3729

Merged
hsbt merged 8 commits intoruby:masterfrom
hsbt:remove-webrick
Dec 10, 2020
Merged

Move webrick library into internal test toolchain#3729
hsbt merged 8 commits intoruby:masterfrom
hsbt:remove-webrick

Conversation

@hsbt
Copy link
Copy Markdown
Member

@hsbt hsbt commented Nov 2, 2020

@hsbt hsbt mentioned this pull request Dec 2, 2020
@hsbt hsbt marked this pull request as ready for review December 10, 2020 09:03
@hsbt hsbt merged commit e7433a3 into ruby:master Dec 10, 2020
@hsbt hsbt deleted the remove-webrick branch December 10, 2020 09:07
yahonda added a commit to yahonda/rails that referenced this pull request Dec 13, 2020
Railties CI against Ruby 3.0.0-dev has been failing
since https://buildkite.com/rails/rails/builds/73338#51165eef-b631-4f9c-8e98-fc210e71e6d1

This pull request addresses the following error.

```ruby
$ ruby -v
ruby 3.0.0dev (2020-12-13T04:39:57Z master c7530f0d56) [x86_64-linux]
$ ruby -Itest -Ilib -I../activesupport/lib -I../actionpack/lib -I../actionview/lib -I../activemodel/lib test/commands/server_test.rb
... snip ...
Run options: --seed 54404

.E

Error:
Rails::Command::ServerCommandTest#test_served_url:
LoadError: cannot load such file -- webrick
    test/commands/server_test.rb:292:in `test_served_url'

rails test test/commands/server_test.rb:289

........................

Finished in 0.303746s, 85.5977 runs/s, 177.7799 assertions/s.
26 runs, 54 assertions, 0 failures, 1 errors, 0 skips
$
```

Related to
ruby/ruby#3729
https://bugs.ruby-lang.org/issues/17303
tagliala added a commit to tagliala/simplecov that referenced this pull request Dec 22, 2020
webrick has been removed from stdlib in Ruby 3.0. This change allows
specs to start with a pristine 3.0 gemset

Ref:
- https://bugs.ruby-lang.org/issues/17303
- ruby/ruby#3729
tagliala added a commit to tagliala/simplecov that referenced this pull request Dec 22, 2020
webrick has been removed from stdlib in Ruby 3.0. This change allows
specs to start with a pristine 3.0 gemset

Ref:
- https://bugs.ruby-lang.org/issues/17303
- ruby/ruby#3729
PragTob pushed a commit to simplecov-ruby/simplecov that referenced this pull request Dec 22, 2020
webrick has been removed from stdlib in Ruby 3.0. This change allows
specs to start with a pristine 3.0 gemset

Ref:
- https://bugs.ruby-lang.org/issues/17303
- ruby/ruby#3729
brettchalupa added a commit to brettchalupa/graphql-docs that referenced this pull request Oct 14, 2022
Webrick was removed from the Ruby stdlib in late 2020 (see
https://bugs.ruby-lang.org/issues/17303 &
ruby/ruby#3729). This adds it as a development
dependency for starting up the simple web server for the sample project.

Webrick seems like a fine fit for a simple server like this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant