Closed
Conversation
Contributor
|
I'm fine with using frozen-string-literal, but please submit this pull request to the upstream repository: https://github.com/ruby/webrick/pulls |
Contributor
Author
|
Got it. I was a bit confused because the source code is stored in ruby/ruby. What's the idea behind keeping it in both repos? |
Contributor
|
This is how all default gems are handled. Ruby ships with the files in the standard library, but the primary repository is separate so gem releases of default gems can be handled independently of Ruby releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frozen_string_literal: trueis in generally a good practice, and here it will make it easier to call some building blocks of WEBricks from places that require objects to be frozen (e.g. Ractors).