Add category to rb_warn_deprecated - #3505
Merged
Merged
Conversation
jeremyevans
approved these changes
Sep 2, 2020
jeremyevans
left a comment
jeremyevans
left a comment
Contributor
There was a problem hiding this comment.
This looks good. I think it results in some duplication, but that can be refactored later.
Contributor
|
I found the bug that causes the spec failures. You need to use: |
PR ruby#3418 added a category to `rb_warn_deprecated_to_remove` but not to `rb_warn_deprecated`. This adds the same code to `rb_warn_deprecated` so that those warnings also get a category. This change also adds tests for `rb_warn_deprecated` and updates the tests for `rb_warn_deprecated_to_remove` to have clearer names. I've fixed the call to `rb_method_entry` as we need to be using the instance method, not singleton. Feature: https://bugs.ruby-lang.org/issues/17122
eileencodes
force-pushed
the
followup-on-category-warning
branch
from
September 2, 2020 18:58
3a9ceb3 to
f099959
Compare
Member
Author
|
I wasn't able to get around to looking at refactoring this a bit to be less repetitive. Will try to get to it tomorrow. |
Contributor
|
I've already started working on changes locally based on this PR that include such a refactoring, so there is no need. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3418 added a category to
rb_warn_deprecated_to_removebut not torb_warn_deprecated. Thisadds the same code to
rb_warn_deprecatedso that those warnings alsoget a category.
This change also adds tests for
rb_warn_deprecatedand updates thetests for
rb_warn_deprecated_to_removeto have clearer names.Feature: https://bugs.ruby-lang.org/issues/17122