Skip to content

Expose ec -> backtrace (internal) and use it to implement fiber backtrace - #3422

Merged
ioquatix merged 1 commit into
ruby:masterfrom
ioquatix:fiber-backtrace
Aug 17, 2020
Merged

Expose ec -> backtrace (internal) and use it to implement fiber backtrace#3422
ioquatix merged 1 commit into
ruby:masterfrom
ioquatix:fiber-backtrace

Conversation

@ioquatix

Copy link
Copy Markdown
Member

@ioquatix
ioquatix requested review from eregon, ko1, nobu and shyouhei and removed request for nobu August 15, 2020 03:37
@ioquatix

Copy link
Copy Markdown
Member Author

Need to add:

  • tests (here)
  • specs (in ruby/specs)

@shyouhei shyouhei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

@ioquatix

Copy link
Copy Markdown
Member Author

I added some basic tests. If it passes, I'll merge it.

@ioquatix
ioquatix merged commit 0a218a9 into ruby:master Aug 17, 2020
@ioquatix
ioquatix deleted the fiber-backtrace branch August 17, 2020 12:56
@eregon

eregon commented Aug 17, 2020

Copy link
Copy Markdown
Member

specs (in ruby/specs)

FWIW they could be added directly here too under spec/ruby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants