Extract version number from the source#3375
Merged
nobu merged 1 commit intoruby:masterfrom Jul 30, 2020
Merged
Conversation
"requiring version.rb" strategy has some issues. - cannot work when cross-compiling - often introduces wrong namespace - must know the superclasses - costs at each runtime than at build-time etc.
hsbt
approved these changes
Jul 30, 2020
|
Are there any details, redmine link, ...? Solution seems a little hacky to me :/ |
matzbot
pushed a commit
that referenced
this pull request
May 25, 2023
They have version.rb files with same directory. But version.rb have been removed at #3375 There is no reason to locate under the library name of directory.
hsbt
added a commit
to ruby/delegate
that referenced
this pull request
Jun 19, 2023
They have version.rb files with same directory. But version.rb have been removed at ruby/ruby#3375 There is no reason to locate under the library name of directory.
hsbt
added a commit
to ruby/getoptlong
that referenced
this pull request
Jun 19, 2023
They have version.rb files with same directory. But version.rb have been removed at ruby/ruby#3375 There is no reason to locate under the library name of directory.
hsbt
added a commit
to ruby/observer
that referenced
this pull request
Jun 19, 2023
They have version.rb files with same directory. But version.rb have been removed at ruby/ruby#3375 There is no reason to locate under the library name of directory.
hsbt
added a commit
to ruby/ostruct
that referenced
this pull request
Jun 19, 2023
They have version.rb files with same directory. But version.rb have been removed at ruby/ruby#3375 There is no reason to locate under the library name of directory.
hsbt
added a commit
to ruby/pstore
that referenced
this pull request
Jun 19, 2023
They have version.rb files with same directory. But version.rb have been removed at ruby/ruby#3375 There is no reason to locate under the library name of directory.
hsbt
added a commit
to ruby/singleton
that referenced
this pull request
Jun 19, 2023
They have version.rb files with same directory. But version.rb have been removed at ruby/ruby#3375 There is no reason to locate under the library name of directory.
hsbt
added a commit
to ruby/timeout
that referenced
this pull request
Jun 19, 2023
They have version.rb files with same directory. But version.rb have been removed at ruby/ruby#3375 There is no reason to locate under the library name of directory.
hsbt
added a commit
to ruby/weakref
that referenced
this pull request
Jun 19, 2023
They have version.rb files with same directory. But version.rb have been removed at ruby/ruby#3375 There is no reason to locate under the library name of directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"requiring version.rb" strategy has some issues.
etc.