Skip to content

Feature #16812: Allow slicing arrays with ArithmeticSequence - #3241

Merged
mrkn merged 7 commits into
ruby:masterfrom
mrkn:feature/16812
Oct 20, 2020
Merged

Feature #16812: Allow slicing arrays with ArithmeticSequence#3241
mrkn merged 7 commits into
ruby:masterfrom
mrkn:feature/16812

Conversation

@mrkn

@mrkn mrkn commented Jun 19, 2020

Copy link
Copy Markdown
Member

TODO:

  • update documentation after we decide the spec

@mrkn
mrkn requested a review from nobu June 20, 2020 02:07
@mrkn

mrkn commented Jun 20, 2020

Copy link
Copy Markdown
Member Author

@nobu Could you check whether or not ary_make_partial_step correctly handles array’s memory?

Comment thread array.c Outdated
Comment thread array.c Outdated
Comment thread array.c Outdated
Comment thread range.c
@mrkn
mrkn requested a review from nobu June 21, 2020 05:43
@mrkn

mrkn commented Jun 21, 2020

Copy link
Copy Markdown
Member Author

@nobu I fixed ary_make_partial_step. Could you review it again?

@mrkn
mrkn merged commit a6a8576 into ruby:master Oct 20, 2020
@mrkn
mrkn deleted the feature/16812 branch October 20, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants