Remove the 65 size limit for name_err_mesg_to_str #3090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you add a test and I will merge? We should test 66 and probably 121. |
This limit was introduced on Nov 20 1996 in 554b989 Apparently to protect from a buffer overflow: * eval.c (f_missing): オブジェクトの文字列表現が長すぎる時バッファ を書き潰していた However I tested that path with very large strings and it works fine.
casperisfine
force-pushed
the
remove-outdated-name-error-limitation
branch
from
1b99a16 to
8e202a8
Compare
Contributor
Author
|
@tenderlove done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limit was introduced on Nov 20 1996
in 554b989
Apparently to protect from a buffer overflow:
を書き潰していた
However I tested that path with very large strings
and it works fine.
See https://bugs.ruby-lang.org/issues/16832 for more context