Conversation
It ran three times in my fork as above. Now it's frozen. To any that have access, feel free to stop it: |
MSP-Greg
force-pushed
the
actions-mingw
branch
from
75bdb0c to
6101fec
Compare
|
Rebased and pushed updated code. One spec and one test (test-all) were bypassed via the first two commits. One issue that may help in mswin CI is that Actions Windows is changing line endings in the repo...
I started on this for two reasons. First, AppVeyor CI often backs up all of the Ruby repos, and secondly, I expect to move ruby-loco to Actions, and likely similar issues... EDIT: MinGW Actions passed here and also in my fork at: |
MSP-Greg
force-pushed
the
actions-mingw
branch
from
6101fec to
66f2596
Compare
C-API Thread function rb_thread_call_without_gvl
-- runs a C function with the global lock unlocked and unlocks IO with the generic RUBY_UBF_IO
stops/freezes spec tests
See https://bugs.ruby-lang.org/issues/16265
Test times out in CI (both AppVeyor & Actions), cannot repo locally
MSP-Greg
force-pushed
the
actions-mingw
branch
from
66f2596 to
4f1147e
Compare
|
While we have some new skips on Actions compared to AppVeyor, people seem to basically agree that Actions is better than AppVeyor. Besides build time is shorter in Actions. Let me merge this and drop AppVeyor MinGW. Thank you. |
* MinGW - skip spec in spec/ruby/optional/capi/thread_spec.rb
C-API Thread function rb_thread_call_without_gvl
-- runs a C function with the global lock unlocked and unlocks IO with the generic RUBY_UBF_IO
stops/freezes spec tests
See https://bugs.ruby-lang.org/issues/16265
* MinGW - skip test test/resolv/test_dns.rb
Test times out in CI (both AppVeyor & Actions), cannot repo locally
* MinGW - skip test test/ruby/test_thread_queue.rb
* Add Actions mingw.yml
In some cases Prism was either not raising an appropriate `void value
expression` error, or raising that error when the syntax is considered
valid.
To fix this Prism needs to check whether we have other clauses on the
`begin` rather than just returning `cast->statements`.
* If the `cast->statements` are null and the `cast->ensure_clause` is
not null, set the code to `cast->ensure_clause`
* else
* If there is a `cast->rescue_clause`
* Check if `cast->statements` are null and `cast->rescue_clause->statements`
are null, and return `NULL`
* Check if there is an `else_clause`, and set the node to
`cast->else_clause`.
* Otherwise return `cast->statements` as the node
* return `cast->statements` as the node
See tests for test cases. Note I took these directly from CRuby so if
desired I can delete them since the test will now pass. This only fixes
one test in the `test_parse` file, taking failures from 14 to 13.
This fixes `TestParse#test_void_value_in_rhs` and is related to
issue #2791.
ruby/prism@398152b412
2 participants
Starter yaml file for running MinGW builds on Actions.
actions/checkout@v2has been released with more options, etc. Changed to allow CI in forks when not using master branch.make buildandmake testseem to consistently succeed/pass.make test-allseems to have one or two consistent errors.make test-specis kind of a mess. The 2nd commit is needed to bypass a spec, otherwise the step freezes. See Perform full MSYS2/MinGW update for build, -fstack-protector-strong - spec freeze #2718 and https://bugs.ruby-lang.org/issues/16265. But, with that change, the last run in my fork showed '58 failures, 2 errors'Since
actions/setup-ruby@v1/disk images are not current, this uses an action of mine (MSP-Greg/actions-ruby@master) that install currents MinGW Rubies, corrects/cleans the Actions path, and allows package installation on the MSYS2 install.With most of these issues not happening in AppVeyor CI, I haven't had time to look for why the CI platform is affecting things.