Perform full MSYS2/MinGW update for build, -fstack-protector-strong - spec freeze#2718
Closed
MSP-Greg wants to merge 2 commits intoruby:masterfrom
Closed
Perform full MSYS2/MinGW update for build, -fstack-protector-strong - spec freeze#2718MSP-Greg wants to merge 2 commits intoruby:masterfrom
MSP-Greg wants to merge 2 commits intoruby:masterfrom
Conversation
vinistock
pushed a commit
to vinistock/ruby
that referenced
this pull request
Dec 3, 2019
* Handle BasicObject in drb Also fix a bug in rescue clause of any_to_s because sprintf does not handle the %l modifier. Fixes [Bug ruby#7833] * Do not send a reply to the client if there is a connection error This allows for normal TCP shutdown (fin-ack-fin-ack instead of fin-ack-push-rst). Patch from [email protected] (Pierre-Alexandre Meyer). Fixes [Bug ruby#2339] * Detect fork and do not reuse forked connections in drb This associates each DRbConn with a pid, and if the pid changes, it closes any DRbConns in the pool with a pid that no longer matches. This fixes DRb servers from sending messages intended for one client to another client after forking. Fixes [Bug ruby#2718] Fixes [Bug ruby#14471]
MSP-Greg
changed the title
Merged
Member
|
Thanks to you, we moved to GitHub Actions now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current MSYS2/minGW gcc update in is not updating all gcc related packages.
ruby/appveyor.yml
Line 103 in 7f2cd2a
This PR updates all packages needed for gcc use in Ruby, similar to a new (or updated) MSYS2 install.
Doing so requires libssp use, otherwise build errors like
undefined references to __*_chkwill occur. See:https://ci.appveyor.com/project/MSP-Greg/ruby/builds/29269011/job/krgmoi642srl63d2#L1054
Second commit adds
-fstack-protector-strongto CFLAGS and LDFLAGS, which fixes the build errors.But, that then causes a spec to freeze
as noted in:
https://bugs.ruby-lang.org/issues/16265