Make Symbol#to_s return a frozen String, the same String for a given Symbol #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@eregon seems like Matz is ok for shipping this as an experiment. So this can be merged now? If so do you think we could also experiment with returning a frozen string for |
Member
Author
|
@byroot Yes, I'll merge this soon before the next preview, I just need to mark the change as experimental.
I think that would require matz's approval. Could you reply on https://bugs.ruby-lang.org/issues/16150#note-18 to ask that? |
* Always the same frozen String for a given Symbol. * Avoids extra allocations whenever calling Symbol#to_s. * See [Feature #16150]
eregon
force-pushed
the
frozen-symbol-to_s
branch
from
6143a04 to
dea6309
Compare
eregon
added a commit
to eregon/rails
that referenced
this pull request
Sep 26, 2019
* String#+@ is available since Ruby 2.3. * See the upstream Ruby change making Symbol#to_s return a frozen String for efficiency: ruby/ruby#2437
This was referenced Sep 26, 2019
This was referenced Sep 26, 2019
Merged
8 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Oct 12, 2019
Follow ruby/ruby#2437. This PR fixes the following `FrozenError` for save_bang_spec.rb ```Failures: % ruby -v ruby 2.7.0dev (2019-10-09T16:08:42Z master 42edb05626) [x86_64-darwin17] % bundle exec rspec ./spec/rubocop/cop/rails/save_bang_spec.rb (snip) 1) RuboCop::Cop::Rails::SaveBang update behaves like checks_common_offense when using update without arguments Failure/Error: inspect_source(method.to_s) FrozenError: can't modify frozen String: "update" Shared Example Group: "checks_common_offense" called from ./spec/rubocop/cop/rails/save_bang_spec.rb:541 # ./spec/rubocop/cop/rails/save_bang_spec.rb:58:in `block (3 levels) in <top (required)>' ```
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test-specandmake test-allboth pass, with only one change intest-all.