ZJIT: Limit local reloads after send to ones syntactically written to - #17417
Merged
XrXr merged 2 commits intoJul 6, 2026
Merged
Conversation
alanwu-shopify-inc
force-pushed
the
zjit-filter-send-with-block-local-reloads
branch
2 times, most recently
from
June 26, 2026 17:10
de62fb7 to
ee0cbf2
Compare
alanwu-shopify-inc
pushed a commit
to Shopify/ruby
that referenced
this pull request
Jun 30, 2026
…ir-opt` I had a go trying to fix these at <ruby#17417>, but the full fix is quite involved. Let's skip for now since filtering local reloads fixes correctness issues with inlining in the default configuration.
alanwu-shopify-inc
force-pushed
the
zjit-filter-send-with-block-local-reloads
branch
from
June 30, 2026 17:50
506a8ec to
061e1a5
Compare
alanwu-shopify-inc
marked this pull request as ready for review
June 30, 2026 17:50
k0kubun
approved these changes
Jun 30, 2026
k0kubun
pushed a commit
to k0kubun/ruby
that referenced
this pull request
Jul 1, 2026
…ir-opt` I had a go trying to fix these at <ruby#17417>, but the full fix is quite involved. Let's skip for now since filtering local reloads fixes correctness issues with inlining in the default configuration.
tekknolagi
reviewed
Jul 1, 2026
tekknolagi
approved these changes
Jul 1, 2026
k0kubun
pushed a commit
to k0kubun/ruby
that referenced
this pull request
Jul 2, 2026
…ir-opt` I had a go trying to fix these at <ruby#17417>, but the full fix is quite involved. Let's skip for now since filtering local reloads fixes correctness issues with inlining in the default configuration.
k0kubun
pushed a commit
to k0kubun/ruby
that referenced
this pull request
Jul 2, 2026
…ir-opt` I had a go trying to fix these at <ruby#17417>, but the full fix is quite involved. Let's skip for now since filtering local reloads fixes correctness issues with inlining in the default configuration.
…ir-opt` I had a go trying to fix these at <ruby#17417>, but the full fix is quite involved. Let's skip for now since filtering local reloads fixes correctness issues with inlining in the default configuration.
alanwu-shopify-inc
force-pushed
the
zjit-filter-send-with-block-local-reloads
branch
from
July 6, 2026 17:36
09df5d6 to
4da9273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step towards addressing Shopify#976, but not fixed in general even though the particular instance in the issue is fixed.
You can still trick ZJIT into issuing a reload without a matching dominating store with a trivially inlined
setlocalin a block:We'll add matching stores visible in HIR as part of using stack maps for locals. This is a step towards that, too.