[Bug #21551] Enhance Ractor::IsolationError with outer_variables, yield_called - #16175
Open
AlexaCampusano wants to merge 1 commit into
Open
[Bug #21551] Enhance Ractor::IsolationError with outer_variables, yield_called#16175AlexaCampusano wants to merge 1 commit into
Ractor::IsolationError with outer_variables, yield_called#16175AlexaCampusano wants to merge 1 commit into
Conversation
…ield sign in order to have better error highlighting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #16163
On its predecessor, I worked on raising
Ractor::IsolationErrorrather thanArgumentErrorfor isolation related errors such as accessing outer variables inside a Ractor, or yielding.This PR enriches the Ractor::IsolationError class with two new attributes:
outer_variables— returns the list of outer variable names referenced in the blockyield_called— returns whether the block uses yieldThe purpose of these additions is to provide context about what caused the isolation violation, which can be used in a follow-up PR to improve
ErrorHighlightsupport for these errors.