Fiber scheduler: invoke #io_write hook on IO flush#15609
Merged
Conversation
❌ 1/67066 Tests Failedtest/ruby/test_gc.rb#test_stat |
noteflakes
marked this pull request as ready for review
December 17, 2025 11:02
Previously, calling IO#flush or closing an IO with unflushed buffered writes would just invoke `#blocking_operation_wait` and flush the write buffer using a `write` syscall. This change adds flushing through the fiber scheduler by invoking the `#io_write` hook.
ioquatix
force-pushed
the
io_flush_fiber_scheduler
branch
from
December 19, 2025 09:19
028ac76 to
04b4808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/21789
Previously, calling
IO#flushor closing an IO with unflushed buffered writes would just invoke#blocking_operation_waitand flush the write buffer using awritesyscall. This change adds flushing through the fiber scheduler by invoking the#io_writehook.cc @ioquatix