Skip to content

win32: Support more clockid_t #14866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nobu merged 2 commits into from
Oct 17, 2025
Merged

win32: Support more clockid_t #14866

nobu merged 2 commits into from
Oct 17, 2025

Conversation

@nobu
Copy link
Member

@nobu nobu commented Oct 17, 2025

Add CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID.
But skip such low precision clocks to measure performances.

@launchable-app
Copy link

launchable-app bot commented Oct 17, 2025 •
edited
Loading

❌ 2/62455 Tests Failed

test/rubygems/test_gem_remote_fetcher_local_ssl_server.rb#test_do_not_allow_insecure_ssl_connection_by_default
test/ruby/test_iseq.rb#test_parent_iseq_mark 
Error:
TestISeq#test_parent_iseq_mark:
Test::Unit::ProxyError: execution of Test::Unit::CoreAssertions#assert_separately expired timeout (20 sec)
pid 5576 exit 1
| �[7;1m2580:1760676369.222:ab14:�[m<error>
| BAgw
| �[7;1m2580:1760676369.222:ab14:�[m</error>
| �[7;1m2580:1760676369.222:ab14:�[massertions=1
| 

    D:/a/ruby/ruby/src/test/ruby/test_iseq.rb:368:in 'TestISeq#test_parent_iseq_mark'

[-> View Test suite health in main branch]

nobu added 2 commits October 17, 2025 13:21
@nobu
win32: Support more clockid_t
7e3d470 
Add `CLOCK_PROCESS_CPUTIME_ID` and `CLOCK_THREAD_CPUTIME_ID`.
@nobu
Skip low precision clocks to measure performances
43bfc27
@nobu nobu force-pushed the win32-clockid branch 2 times, most recently from fd078c4 to 43bfc27 Compare October 17, 2025 04:22
@nobu nobu enabled auto-merge (rebase) October 17, 2025 05:25
@nobu nobu merged commit 5a23716 into ruby:master Oct 17, 2025
89 of 91 checks passed
@nobu nobu deleted the win32-clockid branch October 17, 2025 05:52
@st0012 st0012 mentioned this pull request Nov 7, 2025
Closed
tompng added a commit to tompng/test-unit-ruby-core that referenced this pull request Nov 9, 2025
@tompng
Sync ruby/ruby#14866
26d8943 
New low-resolution-clock is added in windows.
Sync with ruby/ruby#14866 to use precise clock in performance measurement.
tompng added a commit to tompng/test-unit-ruby-core that referenced this pull request Nov 9, 2025
@tompng
Sync ruby/ruby#14866
80e441f 
Low resolution-clock is added in windows, but it shouldn't be used in assert_linear_performance.
ruby/ruby's core_assertion.rb selects clock that has enough resolution.
This was referenced Nov 9, 2025
Merged
Merged
Merged
hsbt added a commit to ruby/test-unit-ruby-core that referenced this pull request Nov 9, 2025
@hsbt
Merge pull request #20 from tompng/sync_windows_clock_id
b292bba 
Sync ruby/ruby#14866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nobu