Skip to content

Sync Prism#14751

Merged
k0kubun merged 1 commit intoruby:masterfrom
k0kubun:sync-prism
Oct 7, 2025
Merged

Sync Prism#14751
k0kubun merged 1 commit intoruby:masterfrom
k0kubun:sync-prism

Conversation

@k0kubun
Copy link
Copy Markdown
Member

@k0kubun k0kubun commented Oct 7, 2025

to ruby/prism@c89ca2a

The diff is generated by tool/sync_default_gems.rb prism. They seem to come from ruby/prism@474ad42, but ruby tool/sync_default_gems.rb prism 96eccfc70408c3d26f08f0a523be53cb3dd6d25b..d048418c964da70146fb65c49a50205cc148b7f8 doesn't succeed https://github.com/ruby/ruby/actions/runs/18298406027/job/52101460864, so this PR resorts to tool/sync_default_gems.rb prism.

We should improve tool/sync_default_gems.rb to avoid failing the sync like that, but now that we've re-enabled the gem sync at ruby/prism#3673, let's start from the clean slate to make sure future sync doesn't fail just because it's already out-of-sync.

cc: @kddnewton

@k0kubun k0kubun marked this pull request as ready for review October 7, 2025 00:33
@k0kubun k0kubun merged commit e3d4cb5 into ruby:master Oct 7, 2025
78 of 79 checks passed
@k0kubun k0kubun deleted the sync-prism branch October 7, 2025 00:41
Copy link
Copy Markdown
Contributor

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants