Wrap do_fast_fallback_getaddrinfo with rb_thread_prevent_fork#12366
Merged
shioimm merged 1 commit intoruby:masterfrom Dec 18, 2024
Merged
Conversation
Referencing PR ruby#10864, wrap `do_fast_fallback_getaddrinfo` with `rb_thread_prevent_fork` to avoid fork safety issues. `do_fast_fallback_getaddrinfo` internally uses getaddrinfo(3), leading to fork safety issues, as described in PR ruby#10864. This change ensures that `do_fast_fallback_getaddrinfo` is guarded by `rb_thread_prevent_fork`, preventing fork during its execution and avoiding related issues.
shioimm
force-pushed
the
do_fast_fallback_getaddrinfo-in-rb_thread_prevent_fork
branch
from
570336b to
781a0a7
Compare
✅ All Tests passed!✖️no tests failed ✔️65476 tests passed(3 flakes) |
✅ All Tests passed!✖️no tests failed ✔️64750 tests passed(2 flakes) |
7 similar comments
✅ All Tests passed!✖️no tests failed ✔️64750 tests passed(2 flakes) |
✅ All Tests passed!✖️no tests failed ✔️64750 tests passed(2 flakes) |
✅ All Tests passed!✖️no tests failed ✔️64750 tests passed(2 flakes) |
✅ All Tests passed!✖️no tests failed ✔️64750 tests passed(2 flakes) |
✅ All Tests passed!✖️no tests failed ✔️64750 tests passed(2 flakes) |
✅ All Tests passed!✖️no tests failed ✔️64750 tests passed(2 flakes) |
✅ All Tests passed!✖️no tests failed ✔️64750 tests passed(2 flakes) |
shioimm
changed the title
getaddrinfo(3) with rb_thread_prevent_forkdo_fast_fallback_getaddrinfo with rb_thread_prevent_fork
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referencing PR #10864,
wrap
do_fast_fallback_getaddrinfowithrb_thread_prevent_forkto avoid fork safety issues.do_fast_fallback_getaddrinfointernally uses getaddrinfo(3), leading to fork safety issues, as described in PR #10864. This change ensures thatdo_fast_fallback_getaddrinfois guarded byrb_thread_prevent_fork,preventing fork during its execution and avoiding related issues.