-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Make benchmark to bundled gems #11492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ruby wants to bundle it: ruby/ruby#11492 This is pretty much all the gem does anyways: https://github.com/ruby/benchmark/blob/8d2c8a0d7ca72bff7e97a4800e16c72f232867e4/lib/benchmark.rb#L311-L315 I removed the `bench_cop` rake task since it uses `benchmark` and I believe it just isn't very useful. Dedicated tools like `vernier` or `stackprof` (which has buildin support in RuboCop these days) are much more suited for the task.
Ruby wants to bundle it: ruby/ruby#11492 This is pretty much all the gem does anyways: https://github.com/ruby/benchmark/blob/8d2c8a0d7ca72bff7e97a4800e16c72f232867e4/lib/benchmark.rb#L311-L315
Ruby wants to bundle it: ruby/ruby#11492 This is pretty much all the gem does anyways: https://github.com/ruby/benchmark/blob/8d2c8a0d7ca72bff7e97a4800e16c72f232867e4/lib/benchmark.rb#L311-L315
Ruby wants to bundle it: ruby/ruby#11492 The benchmark gem does it like this for 14 years already so I don't imagine problems with older ruby versions
Ruby wants to bundle it: ruby/ruby#11492 The benchmark gem does it like this for 14 years already so I don't imagine problems with older ruby versions
Ruby wants to bundle it: ruby/ruby#11492 The benchmark gem does it like this for 14 years already so I don't imagine problems with older ruby versions
Ruby plans to bundle it: ruby/ruby#11492 That means, in the next ruby version requiring it without it appearing in the gemspec will warn, and the release after that will error.
Ruby wants to bundle it: ruby/ruby#11492 This is pretty much all the gem does anyways: https://github.com/ruby/benchmark/blob/8d2c8a0d7ca72bff7e97a4800e16c72f232867e4/lib/benchmark.rb#L311-L315 I removed the `bench_cop` rake task since it uses `benchmark` and I believe it just isn't very useful. Dedicated tools like `vernier` or `stackprof` (which has buildin support in RuboCop these days) are much more suited for the task.
Ruby plans to make `benchmark` a bundled gem: ruby/ruby#11492 It doesn't make much sense to continue this core extension since rails would need to add it to its gemspec to continue offering it for what basically amounts to `x * 1000`. Since requiring it could emit a warning, add it to the gemspec until it can later be removed again with Rails 8.1 The benchmark generator will continue to work as usual: It adds `benchmark-ips` to the users Gemfile, which in turn should depend on `benchmark`: evanphx/benchmark-ips#141
|
https://bugs.ruby-lang.org/issues/20309 doesn't mention moving I think it's valuable that |
|
Do not rush to me. I will discuss this at next meeting. |
|
I didn't mean to rush you, but yes I think it would be good to have some discussion about it on a Redmine ticket. FWIW I found out about this PR from @Earlopain who started making PRs assuming |
|
I merged this change to #11560 |
Ruby plans to make `benchmark` a bundled gem: ruby/ruby#11492 It doesn't make much sense to continue this core extension since rails would need to add it to its gemspec to continue offering it for what basically amounts to `x * 1000`. Since requiring it could emit a warning, add it to the gemspec until it can later be removed again with Rails 8.1 The benchmark generator will continue to work as usual: It adds `benchmark-ips` to the users Gemfile.
Ruby plans to make `benchmark` a bundled gem: ruby/ruby#11492 It doesn't make much sense to continue this core extension since rails would need to add it to its gemspec to continue offering it for what basically amounts to `x * 1000`. Since requiring it could emit a warning, add it to the gemspec until it can later be removed again with Rails 8.1 The benchmark generator will continue to work as usual: It adds `benchmark-ips` to the users Gemfile.
Ruby plans to make `benchmark` a bundled gem: ruby/ruby#11492 It doesn't make much sense to continue this core extension since rails would need to add it to its gemspec to continue offering it for what basically amounts to `x * 1000`. Since requiring it could emit a warning, add it to the gemspec until it can later be removed again with Rails 8.1 The benchmark generator will continue to work as usual: It adds `benchmark-ips` to the users Gemfile.
Ruby plans to make `benchmark` a bundled gem: ruby/ruby#11492 It doesn't make much sense to continue this core extension since rails would need to add it to its gemspec to continue offering it for what basically amounts to `x * 1000`. Since requiring it could emit a warning, add it to the gemspec until it can later be removed again with Rails 8.1 The benchmark generator will continue to work as usual: It adds `benchmark-ips` to the users Gemfile.
Ruby plans to make `benchmark` a bundled gem: ruby/ruby#11492 It doesn't make much sense to continue this core extension since rails would need to add it to its gemspec to continue offering it for what basically amounts to `x * 1000`. Since requiring it could emit a warning, add it to the gemspec until it can later be removed again with Rails 8.1 The benchmark generator will continue to work as usual: It adds `benchmark-ips` to the users Gemfile.
Ruby plans to make `benchmark` a bundled gem: ruby/ruby#11492 It doesn't make much sense to continue this core extension since rails would need to add it to its gemspec to continue offering it for what basically amounts to `x * 1000`. Since requiring it could emit a warning, add it to the gemspec until it can later be removed again with Rails 8.1 The benchmark generator will continue to work as usual: It adds `benchmark-ips` to the users Gemfile.
Ruby plans to make `benchmark` a bundled gem: ruby/ruby#11492 It doesn't make much sense to continue this core extension since rails would need to add it to its gemspec to continue offering it for what basically amounts to `x * 1000`. Since requiring it could emit a warning, add it to the gemspec until it can later be removed again with Rails 8.1 The benchmark generator will continue to work as usual: It adds `benchmark-ips` to the users Gemfile.
https://bugs.ruby-lang.org/issues/20309