Make the test suite is compatible with --enable-frozen-string-literal - #10235
Merged
Merged
Conversation
casperisfine
force-pushed
the
enable-frozen-string-literal-compile
branch
2 times, most recently
from
March 13, 2024 12:02
f195b9c to
04f45a7
Compare
This comment has been minimized.
This comment has been minimized.
casperisfine
force-pushed
the
enable-frozen-string-literal-compile
branch
4 times, most recently
from
March 13, 2024 14:22
b583fa5 to
d5ae988
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
eregon
reviewed
Mar 13, 2024
eregon
reviewed
Mar 13, 2024
casperisfine
force-pushed
the
enable-frozen-string-literal-compile
branch
from
March 13, 2024 17:19
0edf492 to
0ab9078
Compare
casperisfine
pushed a commit
to casperisfine/mspec
that referenced
this pull request
Mar 13, 2024
Ref: ruby/ruby#10235 As discussed upstream, the mutability is only used in one spec, `path.rb`: ```ruby @name = +"file_to_path" @path = tmp(@name) ``` For all the others it doesn't matter if the argument is mutated or not.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
pushed a commit
to casperisfine/mspec
that referenced
this pull request
Mar 13, 2024
Ref: ruby/ruby#10235 As discussed upstream, the mutability is only used in one spec, `path.rb`: ```ruby @name = +"file_to_path" @path = tmp(@name) ``` For all the others it doesn't matter if the argument is mutated or not.
eregon
pushed a commit
to ruby/mspec
that referenced
this pull request
Mar 13, 2024
Ref: ruby/ruby#10235 As discussed upstream, the mutability is only used in one spec, `path.rb`: ```ruby @name = +"file_to_path" @path = tmp(@name) ``` For all the others it doesn't matter if the argument is mutated or not.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
pushed a commit
to casperisfine/spec
that referenced
this pull request
Mar 13, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step.
casperisfine
force-pushed
the
enable-frozen-string-literal-compile
branch
from
March 14, 2024 16:01
0ab9078 to
c38e212
Compare
casperisfine
changed the title
casperisfine
force-pushed
the
enable-frozen-string-literal-compile
branch
from
March 14, 2024 16:03
c38e212 to
43f2a04
Compare
casperisfine
marked this pull request as ready for review
March 14, 2024 16:12
As preparation for https://bugs.ruby-lang.org/issues/20205 making sure the test suite is compatible with frozen string literals is making things easier.
casperisfine
force-pushed
the
enable-frozen-string-literal-compile
branch
from
March 14, 2024 16:25
43f2a04 to
940a9ae
Compare
byroot
enabled auto-merge (rebase)
March 14, 2024 16:26
maximecb
approved these changes
Mar 14, 2024
eregon
added a commit
to casperisfine/spec
that referenced
this pull request
Mar 14, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step. Co-authored-by: Benoit Daloze <[email protected]>
eregon
added a commit
to casperisfine/spec
that referenced
this pull request
Mar 14, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step. Co-authored-by: Benoit Daloze <[email protected]>
eregon
added a commit
to ruby/spec
that referenced
this pull request
Mar 14, 2024
Extracted from: ruby/ruby#10235 Ref: https://bugs.ruby-lang.org/issues/20205 Ruby will gradually move towards enabling frozen string literals by default. Making the ruby spec suite compatible is a good first step. Co-authored-by: Benoit Daloze <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As preparation for https://bugs.ruby-lang.org/issues/20205 making sure the test suite is compatible with frozen string literals is making things easier.
Note that
spec/is being handled upstream: ruby/spec#1142