🐛 Fix SequenceSet#delete?(num..num) to return set (backport to 0.5) #585
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the rdoc, using a range with `#delete?` should return a sequence set (or nil), but the check came after importing the input, and was based on whether the imported run contained multiple values. So deleting a single number range (e.g: `1..1` or `"1:1"`) would return a number not a set.
nevans
added
bug
nevans
deleted the
backport-0.5/sequence_set/fix-deletep-with-single-member-range
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #583 to
v0.5-stable. From that PR: