♻️ Reorganize SequenceSet internals
#568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit should not change _any_ code, except for the order in which the methods (and constant) are defined. This also adds vim foldmarkers. In general, I think that needing manual foldmarkers is a code smell, and this is no different. It usually means some new classes and objects should be extracted. I've avoiding extracting new classes mostly for performance reasons: new objects require extra allocations, and I want that change to be justified by accompanying some performance improvements. (On the other hand, subclassing Array will allow us to better organize the code while avoiding extra allocations.)
nevans
added
the
sequence-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not change any code, except for the order in which the methods (and constant) are defined.
This also adds vim foldmarkers. In general, I think that needing manual foldmarkers is a code smell, and this is no different. It usually means some new classes and objects should be extracted. I've avoiding extracting new classes mostly for performance reasons: new objects require extra allocations, and I want that change to be justified by accompanying some performance improvements. (On the other hand, subclassing Array will allow us to better organize the code while avoiding extra allocations.)
But also, this is preparatory for much bigger changes, which almost certainly will introduce new classes for the internal data structures. (See #484.)