♻️ Coalesce entries in SequenceSet#append #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can build an ordered set from an enumarable input as simply as `enum.inject(Net::IMAP::SequenceSet.new, &:append)`. But, prior to this change, that could easily give you very inefficient output, e.g: it might return `9,1,2,3,4,5,6,7,8`. With this change, the same input will return `9,1:8`. This also short-circuits whenever `@string` is `nil`, avoiding string generation. This significantly improves performance when the set remains monotonically sorted.
nevans
added
the
sequence-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can build an ordered set from an enumarable input as simply as
enum.inject(Net::IMAP::SequenceSet.new, &:append). But, prior to this change, that could easily give you very inefficient output, e.g: it might return9,1,2,3,4,5,6,7,8. With this change, the same input will return9,1:8.This also short-circuits whenever
@stringisnil, avoiding string generation. This significantly improves performance when the set remains monotonically sorted.