✨ Add SequenceSet#xor! for in-place XOR
#550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is simply a mutating version of `#^` or `#xor`. Although there is room for big performance improvement here, the algorithm remains unchanged, so any performance improvement is small.
nevans
force-pushed
the
sequence_set/xor-bang
branch
from
94a6a36 to
b9e99dc
Compare
nevans
added
the
sequence-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds a mutating version of
#^or#xor.Although there is room for big performance improvement here, the algorithm remains basically unchanged. But the argument is only coerced into a SequenceSet once (rather than twice) which should provide a small performance boost.