✅ Organize test files #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test/net/imap/test_imap_*` files are all client integration tests that create a fake server socket and connect to it, testing a method or a cluster of methods on `Net::IMAP`. All other test files are for unit tests for a specific class or module.
Many of the tests that remain in `test_imap` are connection related or edge cases, e.g: unexpected EOF, STARTTLS stripping, TLS with CA file, send_command argument translation. Those will probably stay in this file indefinitely. But some of them simply haven't been translated to `with_fake_server` yet and thus can't easily be moved, e.g: the tests for idle, disconnect, append, id. Those will be moved eventually.
Collaborator
Author
|
If you have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Test::Unit::TestCasemonkeypatch has been converted into aNet::IMAP::TestCasesubclass ofTest::Unit::TestCase. Common#setupand#teardownhas been moved into that class.The
test/net/imap/test_imap_*files are all client integration tests that create a fake server socket and connect to it, testing a method or a cluster of methods onNet::IMAP. All other test files are (or should be) for a specific class or module. Several files andTestCaseclasses were renamed to be consistent with this.Most of the tests in
test/net/imap/test_imap.rbhave been moved into files specific to a method of cluster of methods onNet::IMAP. Some connected integration tests onNet::IMAPwere already in their own files specific to a method of cluster of methods, but new files were created for the following methods:#authenticate#closeand#unselect#enable#expungeand#uid_expunge#fetchand#uid_fetch#searchand#uid_search#selectand#examine#storeand#uid_storeUIDPLUSextension (not based on specific methods and may be moved/renamed)