Skip to content

✨ Allow obj.to_sequence_set => nil in try_convert #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nevans merged 1 commit into from
Aug 29, 2025
Merged

✨ Allow obj.to_sequence_set => nil in try_convert #512

nevans merged 1 commit into from
Aug 29, 2025

Conversation

@nevans
Copy link
Collaborator

@nevans nevans commented Aug 29, 2025

If obj.to_sequence_set returns nil, then SequenceSet.try_convert should return nil. This is consistent with how ruby's built-in try_convert methods work.

@nevans
✨ Allow obj.to_sequence_set => nil in try_convert
4c35745 
If `obj.to_sequence_set` returns `nil`, then `SequenceSet.try_convert`
should return `nil`.  This is consistent with how ruby's built-in
`try_convert` methods work.
@nevans nevans added the enhancement New feature or request label Aug 29, 2025
@nevans nevans merged commit d027cd2 into master Aug 29, 2025
78 of 85 checks passed
@nevans nevans deleted the sequence_set/allow-to_sequence_set-nil branch August 29, 2025 16:34
@nevans nevans added the sequence-set Any code the IMAP `sequence-set` data type or grammar rule, especially the SequenceSet class. label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request sequence-set Any code the IMAP `sequence-set` data type or grammar rule, especially the SequenceSet class.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nevans