🐛 Fix inconsistently frozen SequenceSet#[] result #458
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
changed the base branch from
sequence-set-slice-exclusive-range-ending-in-zero
to
master
This maybe isn't actually documented very well (or at all...) but most SequenceSet transform methods return a frozen result when +self+ is frozen and a mutable result when +self+ is mutable. Except +limit+ which always returns a frozen result. And (before this commit) +slice+, which inconsistently returned with matching frozen status when the result wasn't empty, but always returned a frozen set when the result _was_ empty. Adding these tests exposed a much more significant bug: `SequenceSet#xor` mutates the reciever.
nevans
force-pushed
the
sequence_set/fix-slice-inconsistent-frozen
branch
from
4918584 to
1e2b599
Compare
nevans
added
the
sequence-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This maybe isn't actually documented very well (or at all...?) but most SequenceSet transform methods return a frozen result when
selfis frozen and a mutable result whenselfis mutable. Exceptlimitwhich always returns a frozen result. And (before this commit)slice, which inconsistently returned with matching frozen status when the result wasn't empty, but always returned a frozen set when the result was empty.(Adding these tests exposed a
much more significantbug:SequenceSet#xormutates the receivercrashes when the set is frozen: #457.)