✨ Add #extract_responses method
#330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to ActiveSupport's Array#extract!. Yields all of the unhandled #responses for a single response type. Removes and returns the responses for which the block returns a true value. Extracting responses is synchronized with other threads. The lock is released before returning.
This was referenced Oct 13, 2024
nevans
added a commit
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Net::IMAP#extract_responses, which behaves similarly to ActiveSupport's Array#extract! (which is a method I often wish we had in ruby core!).Yields all of the unhandled
#responsesfor a single response type. Removes and returns the responses for which the block returns a true value.Extracting responses is synchronized with other threads. The lock is released before returning.