-
Notifications
You must be signed in to change notification settings - Fork 34
Comparing changes
Open a pull request
base repository: ruby/net-imap
base: 364869b
head repository: ruby/net-imap
compare: f76d433
- 16 commits
- 5 files changed
- 2 contributors
Commits on Apr 26, 2025
-
🐛 Check for Ractor (for JRuby, TruffleRuby)
This is the same code I used in the `v0.4-stable` backport. I didn't use it in the main branch because the minimum ruby version is 3.1. But that breaks when JRuby and TruffleRuby try to `require "net/imap"`. Fixes #452.
Configuration menu - View commit details
-
Copy full SHA for 4e14547 - Browse repository at this point
Copy the full SHA 4e14547View commit details
Commits on Apr 28, 2025
-
⬆️ Bump step-security/harden-runner from 2.11.1 to 2.12.0 (#455)
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.11.1 to 2.12.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@c6295a6...0634a26) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c362be8 - Browse repository at this point
Copy the full SHA c362be8View commit details
Commits on Apr 29, 2025
-
🐛 Fix
SequenceSet#slicewith range(start...0)The bug was that exclusive ranges ending in zero would be converted to end on `-1`, which would be interpretted as the last value in the range.
Configuration menu - View commit details
-
Copy full SHA for 16e60a4 - Browse repository at this point
Copy the full SHA 16e60a4View commit details -
🐛 Fix inconsistently frozen SequenceSet#[] result
This maybe isn't actually documented very well (or at all...) but most SequenceSet transform methods return a frozen result when +self+ is frozen and a mutable result when +self+ is mutable. Except +limit+ which always returns a frozen result. And (before this commit) +slice+, which inconsistently returned with matching frozen status when the result wasn't empty, but always returned a frozen set when the result _was_ empty. Adding these tests exposed a much more significant bug: `SequenceSet#xor` mutates the reciever.
Configuration menu - View commit details
-
Copy full SHA for ac7f7b9 - Browse repository at this point
Copy the full SHA ac7f7b9View commit details -
🐛
SequenceSet#xorshould not modifyself`set ^ other` and `set.xor other` are supposed to be safe transforms. But, unfortunately, they modified the receiver if it wasn't frozen, and crashed when it was! The fix is trivial: convert `self` to `dup`.
Configuration menu - View commit details
-
Copy full SHA for 59f259e - Browse repository at this point
Copy the full SHA 59f259eView commit details -
🐛 Fix SequenceSet#slice when length > result size
The goal is for `#[]` (aliased as `#slice`) to behave similarly to `Array#[]`/`Array#slice`. When `Array#slice` has a length or range that extends beyond the end of the array, they simply return everything up to the end.
Configuration menu - View commit details
-
Copy full SHA for 14c011e - Browse repository at this point
Copy the full SHA 14c011eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cd0ca8 - Browse repository at this point
Copy the full SHA 9cd0ca8View commit details -
✨ Add
SequenceSet#min(count)and#max(count)When `count` is given to either of these methods, a new `SequenceSet` is returned, containing only the last `count` numbers. An empty SequenceSet is returned when `self` is empty. The goal is for these to behave similarly to `Array#min`/`#max` when they are given a count.
Configuration menu - View commit details
-
Copy full SHA for eb5dd29 - Browse repository at this point
Copy the full SHA eb5dd29View commit details -
🔀 Merge pull request #460 from ruby/sequence_set/min-max-with-count
✨ Add `SequenceSet#min(count)` and `#max(count)`
Configuration menu - View commit details
-
Copy full SHA for da45d8c - Browse repository at this point
Copy the full SHA da45d8cView commit details -
✨ Add
SequenceSet#aboveandSequenceSet#belowThese are just sugar over `set - (..num)` and `set - (num..)`. They are included because they can sometimes make the code much easier to read than doing set algebra with `-` or `&`.
Configuration menu - View commit details
-
Copy full SHA for e1e0ecb - Browse repository at this point
Copy the full SHA e1e0ecbView commit details -
✅ Add tests for
SequenceSet#xorI'm not sure how this escaped testing before, but yikes!
Configuration menu - View commit details
-
Copy full SHA for 17e50b7 - Browse repository at this point
Copy the full SHA 17e50b7View commit details -
✅ Add basic fuzz tests for SequenceSet operators
I almost accidentally committed a big bug for `#xor`. Yikes! I decided to take that opportunity to simply add some randomized tests on all of the set operators, based on set identities that should always hold true. These can also be used for microbenchmarks and profiling of SequenceSet.
Configuration menu - View commit details
-
Copy full SHA for c6e2520 - Browse repository at this point
Copy the full SHA c6e2520View commit details -
📚 Various
SequenceSetrdoc improvements* Links back to "Ordered and Normalized Sets". * Small updates to `*` description. * Small updates to `min`, `max`, `minmax` summary. * Added more "related" links. * Added more "Set identities" sections to set operators.
Configuration menu - View commit details
-
Copy full SHA for 6f6e8ee - Browse repository at this point
Copy the full SHA 6f6e8eeView commit details -
🔀 Merge pull request #464 from ruby/sequence_set/set_op_fuzz_tests
✅ Test `SequenceSet#xor` and fuzz test all set operations
Configuration menu - View commit details
-
Copy full SHA for d70f7fd - Browse repository at this point
Copy the full SHA d70f7fdView commit details -
🔀 Merge pull request #465 from ruby/sequence_set/improved-rdoc
📚 Various `SequenceSet` rdoc improvements
Configuration menu - View commit details
-
Copy full SHA for fc9948e - Browse repository at this point
Copy the full SHA fc9948eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f76d433 - Browse repository at this point
Copy the full SHA f76d433View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 364869b...f76d433